Changing order status to complete gives user an extra listing for free

[Laconicsky]

Issue:

• User buys a package for one listing.
• After payment, the order status changes to processing.
• User gets package for one listing.
• Listing is published. The package is reset. So far it works OK.
• Now me/admin changes the order status to Completed manually.
• Then the user receives a free package for one listing - THIS IS THE ERROR

I first reached out to your support with the bug on 22nd April 2023.

This is the same issue that has been reported here (and by other users on the forum going back to last year): Problem with reducing the package limit (+solution) - #6 by Dominik

@yevhen acknowledges in that thread on 8th Feb 2023 that this is a bug and is going to be fixed as soon as possible.

The user reporting this issue in that thread also provides a root cause and a workaround that I have applied and tested and found to be working in my most recent thread on this issue:

User listing submitted without selecting package

Hi Andrii, The issue is now reproducible. You have an email at your support address with step by step instructions on how to reproduce the issue including a link for you to gain temporary access to my site. I also included a video showing the issue occurring as I reproduced it. I sent the first email over a week ago, didn’t hear anything back so sent a new email yesterday as the original thread (which has been going since April of this year) had got unwieldy.

Here is the workaround:

What have I done that solved this problem for me:

in file
\plugins\hivepress-paid-listings\includes\components\class-listing-package.php

there is

if ( in_array( $new_status, [ ‘processing’, ‘completed’ ], true ) ) {

Changed to:

if ( in_array( $new_status, [ ‘processing’ ], true ) ) {

( without ‘completed’ - when the order status is changed to “completed” )

I only have instant payments and I always get the “processing” status after a successful payment. When I change the status of the order to “completed” then nothing happens, no additional package for the user is added.

Steps to reproduce

See my email in your support inbox titled ‘Return customers not taken to select package page’ for exact steps and videos.

Actual result

Once the user’s order has been changed from processing to complete they are given a free listing - the next time they post a listing they are not taken to the package selection or payment page as they’ve been given this free package.

Expected result

User should be taken to the package selection page and then payment page.

Extra details

This has been reported by many other users going back to last year:

https://community.hivepress.io/t/user-listing-submitted-without-selecting-package/4344

https://community.hivepress.io/t/some-users-able-to-list-items-without-purchasing-a-listing-package/3736/2

The paid package does not lower the counter

Hello, I found an error. Steps to reproduce Install memberships and paid lising Create a product ABC for the bundle Set the package for 1 ad and for x days. Connect the ABC product with woo. Set the membership package to x days and connect the same product. Register as a seller → post an ad → buy a package Actual result Both the membership package and the announcement package (1 pcs) are added. The ad comes for review by the admin. After approval, it appears on the website as standard…

Questions for HivePress support:

1. Are there any downsides to the workaround above? ie does removing ‘completed’ from the function cause anything else to not behave as it is designed to?
2. If you next update this plugin and haven’t changed this particular piece of code will my code revert to your version of it?
3. Will the customers who have purchased and submitted listings with me prior to me applying the workaround still suffer from this issue when they come back for their second listing?
4. If so is there anything that can be done to remove this additional package they received when changing the status of the order to complete?
5. Do you have an internal ticket open for this issue?
6. If so, when will the fix be built and rolled out?

@ihor you’ve been so helpful in the past - I’m hoping you can provide a permanent fix for this issue.

[Laconicsky]

Any update on this?

[ihor]

Sorry for the delay. The bug is confirmed, thanks for reporting it, we’ll fix it in the next Paid Listings extension update.

[Laconicsky]

Great to hear - any eta?

[ihor]

Currently we’re working on the public roadmap with estimates for HivePress and each extension, it will be completed next week. Once we define the releases queue it will be possible to provide an ETA for Paid Listings, we’ll also try to provide a temporary fix if possible.

[Laconicsky]

There is a workaround already available as provided by one of your users in this thread:

User listing submitted without selecting package

Hi Andrii, The issue is now reproducible. You have an email at your support address with step by step instructions on how to reproduce the issue including a link for you to gain temporary access to my site. I also included a video showing the issue occurring as I reproduced it. I sent the first email over a week ago, didn’t hear anything back so sent a new email yesterday as the original thread (which has been going since April of this year) had got unwieldy.

I have tested it and confirmed it as working and have seen it working correctly with paying customers.

One other thing to flag - even with the workaround in place, any customers that had previously purchased listing have been incorrectly “credited” with an additional listing. This credit remains in place even after the workaround has been applied.

I had to manually get a list of each of the affected vendors and then reset their counter to 0 using the method described in the same post as above.

Will your update also take this into account?

[Laconicsky]

@ihor any update on this? Your public roadmap was due to be completed 2 weeks ago.

The issue still exists - from my testing it appears that marking the order status as complete in Woocommerce > Orders is what causes the additional “credit” to be applied to the vendors account.

[andrii]

Hi,

Sorry for the delay. Unfortunately, this bug is still under development, and there is no exact time when we will fix it, but we will try to do it as soon as possible. As for the roadmap, we will need more time to reorganize and create a public roadmap.